Skip to content

EHN add support for some Keras utilities #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Aug 22, 2018
Merged

EHN add support for some Keras utilities #409

merged 55 commits into from
Aug 22, 2018

Conversation

glemaitre
Copy link
Member

@glemaitre glemaitre commented Mar 1, 2018 •
edited
Loading

This PR attend to provide some utilities for keras:

TODO:

  • Add common test to check multiclass == multilabel-indicator (EHN accept one-vs-all encoding for labels #410)
  • Manage the specificity of the EasyEnsemble and BalanceCascade (overwrite sample)
  • Add user guide documentation
  • Add an example for simple use
  • Add an example for deep training
  • Add substitution
  • What's new
  • Optional depencies

@codecov
Copy link

codecov bot commented Mar 1, 2018 •
edited
Loading

Codecov Report

Merging #409 into master will increase coverage by 0.01%.
The diff coverage is 99.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
+ Coverage   98.75%   98.77%   +0.01%     
==========================================
  Files          70       75       +5     
  Lines        4268     4410     +142     
==========================================
+ Hits         4215     4356     +141     
- Misses         53       54       +1
Impacted Files Coverage Δ
imblearn/utils/_docstring.py 100% <ø> (ø) ⬆️
imblearn/keras/__init__.py 100% <100%> (ø)
imblearn/tensorflow/__init__.py 100% <100%> (ø)
imblearn/tensorflow/_generator.py 100% <100%> (ø)
imblearn/keras/tests/test_generator.py 100% <100%> (ø)
imblearn/keras/_generator.py 98.18% <98.18%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eafae67...abeb011. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Mar 1, 2018 •
edited
Loading

Hello @glemaitre! Thanks for updating the PR.

Line 27:1: E402 module level import not at top of file
Line 28:1: E402 module level import not at top of file
Line 29:1: E402 module level import not at top of file
Line 51:1: E402 module level import not at top of file
Line 52:1: E402 module level import not at top of file
Line 53:1: E402 module level import not at top of file
Line 54:1: E402 module level import not at top of file
Line 55:1: E402 module level import not at top of file
Line 56:1: E402 module level import not at top of file
Line 86:1: E402 module level import not at top of file
Line 93:1: E402 module level import not at top of file
Line 94:1: E402 module level import not at top of file
Line 128:1: E402 module level import not at top of file
Line 129:1: E402 module level import not at top of file
Line 148:1: E402 module level import not at top of file
Line 163:1: E402 module level import not at top of file
Line 185:1: E402 module level import not at top of file
Line 220:1: E402 module level import not at top of file
Line 221:1: E402 module level import not at top of file

Line 9:1: E402 module level import not at top of file
Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file
Line 17:1: E402 module level import not at top of file
Line 18:1: E402 module level import not at top of file

Comment last updated on August 22, 2018 at 09:46 Hours UTC

@glemaitre glemaitre mentioned this pull request Mar 1, 2018
Merged
@glemaitre
Copy link
Member Author

@jorisvandenbossche I think that it could be of interest. Let me know if the API make sense to you.

chkoar
chkoar reviewed Apr 7, 2018
View reviewed changes
imblearn/keras/generator.py Outdated
except ImportError:
# Skip the tests for the examples
import pytest
keras = pytest.importorskip('keras')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line in my box generates the following error:

Skipped: could not import 'keras'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use it to skip the test of the docstring but probably there is something better to do then.

@glemaitre
Copy link
Member Author

Otherwise does it look ok

@glemaitre glemaitre force-pushed the keras_batch_generator branch from 8c4c344 to c056567 Compare August 21, 2018 15:36
@glemaitre glemaitre force-pushed the keras_batch_generator branch from 765dc8a to 324b90c Compare August 22, 2018 09:22
@glemaitre glemaitre merged commit 7c48491 into scikit-learn-contrib:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@chkoar chkoar chkoar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glemaitre @pep8speaks @jorisvandenbossche @chkoar